Extract resources - Githubissues

ryceg / Eigengrau-s-Essential-Establishment-Generator

A town generator that is suitable for out of the box play in any fantasy TTRPG setting.

https://eigengrausgenerator.com

MIT License

822 stars 151 forks source link

Extract resources #738

Closed Glinkis closed 2 years ago

Glinkis commented 2 years ago

Moves all static resources to /gh-pages/static. This way, we don't bundle them into the HTML file, and don't need to copy anything when building.
Updates font loading.
Fixes image sizes/srcset
Removes some legacy css.
Fixes an issue with multiple elements with the same id.

ryceg commented 2 years ago

I've been meaning to bring up the discussion, now's as good a time as any: we should probably think about the name. Resource doesn't really follow any traditional naming convention, and it was only picked because I had the fonts to think about too. Perhaps we should rename it static or something similar?

Glinkis commented 2 years ago

I've been meaning to bring up the discussion, now's as good a time as any: we should probably think about the name. Resource doesn't really follow any traditional naming convention, and it was only picked because I had the fonts to think about too. Perhaps we should rename it static or something similar?

Yes, I agree. static is good. And keeping directory names lowercase is nice.