search

ryceg / Eigengrau-s-Essential-Establishment-Generator

A town generator that is suitable for out of the box play in any fantasy TTRPG setting.
https://eigengrausgenerator.com
MIT License
814 stars 149 forks source link

Expand town data to include famous structures #772

Closed LordUbuntu closed 1 year ago

LordUbuntu commented 1 year ago

What does this do?

This adds an array famousStructure to townData.

It includes the descriptions of several real and imagined famous buildings that towns/cities might be known for. References to stone hedge, the Winchester house, the Prague clock, and more are included along with various random imagined additions. All of these are decorative, so they shouldn't cause any trouble for DM's, just add some flavor to make locations more memorable.

How was this tested? Did you test the changes in the compiled .html file?

I ran yarn test on my local fork and every test passed. I also built the local fork with yarn build and no errors were encountered. The new information/section didn't appear, but that's expected since only the data has been implemented in this PR. I don't know enough (yet) to be able to fully implement the feature, but I think that half of a job is better than no job at all. I hope that this is helpful!

Is there a GitHub Issue that this is resolving?

Yes, this issue inspired me to contribute this meagre part in implementing the feature.

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @ryceg on Vercel.

@ryceg first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
eigengraus-generator ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 5:35AM (UTC)
ryceg commented 1 year ago

Hi! Thanks for starting this- I'd encourage you to have a crack at a full implementation. Check out how the landmark property functions in createTown.ts, and then apply the same logic to this. You can then implement it in the app by mimicking the TownLandmarkRandomizer passage. As a rough guide, we generally try and have enough elements in an array to not worry about someone encountering the same supposedly unique thing in consecutive town generations- eleven is a great start, but I'd like to see triple that before merging this. You can crowd source items in our Discord server, which has channels specifically for this purpose.

LordUbuntu commented 1 year ago

Hi! Thanks for starting this- I'd encourage you to have a crack at a full implementation. Check out how the landmark property functions in createTown.ts, and then apply the same logic to this. You can then implement it in the app by mimicking the TownLandmarkRandomizer passage. As a rough guide, we generally try and have enough elements in an array to not worry about someone encountering the same supposedly unique thing in consecutive town generations- eleven is a great start, but I'd like to see triple that before merging this. You can crowd source items in our Discord server, which has channels specifically for this purpose.

Thanks @ryceg for all your help and advice. I gave a crack at a full implementation but it doesn't seem like it worked. It passes yarn test, and it succeeds with yarn build but the application itself reports several errors, so it looks like I've broken something. Unfortunately, I can't continue work on this because of other obligations. If anyone else would like to give this a shot, they're welcome to, but I'm going to have to abandon it for the foreseeable future.

Thanks for your help and all the best!