rycolab / aclpub2

MIT License
26 stars 38 forks source link

Issue with running or2papers.py script #161

Closed firojalam closed 4 months ago

firojalam commented 8 months ago

Hi I have been trying to the following command, but having the error below. Any suggestion what could be the reason? Note I tried to install openreview package using both from source and pip, none is solving the problem.

python or2papers.py "user" "pass" "EMNLP/2023/Workshop"

requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.openreview.net/notes?invitation=EMNLP%2F2023%2FWorkshop%2FPaper.%2A%2F-%2FDecision&limit=1000&sort=id

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "or2papers.py", line 171, in main(args.username, args.password, args.venue, args.all, args.pdfs) File "or2papers.py", line 50, in main client_acl, invitation=venue + "/Paper.*/-/Decision" File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/tools.py", line 1000, in iterget_notes return efficient_iterget(client.get_notes, desc='Getting Notes', params) File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/tools.py", line 781, in init self.current_batch, total = self.get_function(self.params) File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/openreview.py", line 1059, in get_notes response = self.__handle_response(response) File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/openreview.py", line 130, in __handle_response raise OpenReviewException(error) openreview.openreview.OpenReviewException: {'name': 'ValidationError', 'message': 'invitation must be a prefix regex. If validation passes, any remaining regex characters will be escaped.', 'status': 400, 'details': {'path': '.invitation', 'reqId': '2023-11-07-2049567'}} (b

crux82 commented 7 months ago

@rswilkens if I'm not mistaken you can help with this bug, or can't you?

firojalam commented 7 months ago

Hi @crux82, thanks. @rswilkens, if you can help on this it would be great. Kind of stuck here.

erip commented 7 months ago

I'm running into this as well. I'm not sure if this is related, but I am having trouble even getting a handle on the associated workshops' invitations for EMNLP 2023 workshops:

>>> client.get_group("EMNLP/2023/Workshop/NLP-OSS").invitation is None
True

To me, this suggests that checking a regex against the invitation of None isn't going to work...

rswilkens commented 7 months ago

Hi @firojalam, have you already tried or2program_committee.py? For the or2papers.py, you have to provide the venue ID as it is on OpenReview. For example: python or2papers.py "user" "pass" "EMNLP/2023/Workshop/NLP-OSS"

erip commented 7 months ago

I will say that it doesn't work for me. Same error as @firojalam reported.

rswilkens commented 7 months ago

@erip, did you manage to run the or2program_committee.py?

erip commented 7 months ago

Neither script works.

rswilkens commented 7 months ago

@erip and @firojalam, please try to replace (lines 45 - 53) decision_by_forum = { d.forum: d for d in list( openreview.tools.iterget_notes( client_acl, invitation=venue + "/Paper.*/-/Decision" ) ) if "accept" in d.content["decision"].lower() }
with decision_by_forum = { d.forum: d for d in list( openreview.tools.iterget_notes( client_acl, invitation=venue + "/Paper.*" # "/Paper.*/-/Decision" ) ) if "decision" in d.content and "accept" in d.content["decision"].lower() } in the or2papers.py

firojalam commented 7 months ago

Hi, I solved this using a different approach. Used api version2 and needed to modify the code in different places. Commented line 40-55, and used the following with some additional changes. submissions = client_acl.get_all_notes(content={'venueid': 'your vanue id'})

erip commented 7 months ago

The issue is that EMNLP is running with the v2 API but this client assumes v1 API.

mpurver commented 5 months ago

I'm experiencing the same issue with both scripts when trying to run this for EACL 2024 (venue as EACL/2024/Conference).

zhzhang commented 5 months ago

@mpurver please pull down the branch in this pull request and give it a try: https://github.com/rycolab/aclpub2/pull/165 It incorporates the changes from @rswilkens comment above: https://github.com/rycolab/aclpub2/issues/161#issuecomment-1808244596

crux82 commented 5 months ago

@mpurver if it works I will accept the pull request

@@zhzhang thank you!!!

mpurver commented 5 months ago

@zhzhang no luck so far - it connects fine but the submissions and decision_by_forum lists are both empty.

crux82 commented 5 months ago

I fear that our users do not have visibility of the papers. In any case, we should add some meaningful message in these cases for the users.

crux82 commented 5 months ago

@haroldrubio can you please help us?

haroldrubio commented 5 months ago

I've made some changes in the OR scripts in this PR, please take a look and let me know if you run into some issues

crux82 commented 5 months ago

@haroldrubio Thank you very much for your support! I can download the papers.

@zhzhang I think we will merge https://github.com/rycolab/aclpub2/pull/166 into the main branch.

Unfortunately, or2program_committee.py does not download anything. Could this be a problem related to my publication chair account on OperReview?

@mpurver can you download the committee?

crux82 commented 4 months ago

It should be solved