rycolab / aclpub2

MIT License
26 stars 38 forks source link

Add Compatability with API2 #166

Closed haroldrubio closed 4 months ago

haroldrubio commented 5 months ago

This PR adds support for API2 by making the following changes to:

or2papers.py

or2program_committee.py

zhzhang commented 5 months ago

Is there a reason to keep the original client around? All venues going forward will be on the v2 API no?

haroldrubio commented 5 months ago

I left support for the original client in just in case the scripts need to be re-run on older venues - but if this isn't really a common use case and is just for use with new venues then it could be completely removed

zhzhang commented 5 months ago

I see! I don't think it will be a common use case, would you be able to refactor this PR to only use the v2 API? Thanks!

zhzhang commented 5 months ago

One additional question: I'm trying to run this updated script for EACL 2024. Is the correct venue string eacl.org/EACL/2024/Conference or EACL/2024/Conference? I'm able to get past the venue group validation, but the list of submissions pulled is empty. Not sure if this is an issue with the conference, or with me not having the right program chair permissions, or some other problem.

crux82 commented 5 months ago

@haroldrubio thank you for your great job!

Here are some additional issues, just to keep track:

Thank you again!

Danilo

haroldrubio commented 5 months ago

@zhzhang The correct string is eacl.org/EACL/2024/Conference. The submissions list should be empty because the submissions are only visible to their assigned program committees and the publication and program chairs.

I'll also work on refactoring the code to only use API2

haroldrubio commented 5 months ago

eacl.org/EACL/2024/Workshop/DravidianLangTech/ is not working

python or2papers.py bharathiraja.akr@gmail.com ***** eacl.org/EACL/2024/Workshop/DravidianLangTech/ output eacl.org/EACL/2024/Workshop/DravidianLangTech/ not found

Your venue string has a trailing /, it should work if you trim that character off: eacl.org/EACL/2024/Workshop/DravidianLangTech

haroldrubio commented 5 months ago

I've added some error parsing, can you run it again for your workshop(s) and show me the error now?

haroldrubio commented 5 months ago

While you're in the aclpub2 directory, you should be able to use git pull to get the latest changes

crux82 commented 5 months ago

@bharathichezhiyan as publication chair of EACL I downloaded this material and will upload in your github repository

crux82 commented 5 months ago

@haroldrubio: when downloading the PDFs and attachments (using --all --pdfs), I get this error.

Traceback (most recent call last):
  File "/Users/danilo/progetti/aclpub2/openreview/or2papers.py", line 192, in <module>
    main(args.username, args.password, args.venue, args.all, args.pdfs)
  File "/Users/danilo/progetti/aclpub2/openreview/or2papers.py", line 143, in main
    file_tye = get_content_from(submission, "software").split(".")[-1]

I think it is a problem parsing the metadata of the attachments

Can you please fix it?

crux82 commented 5 months ago

@haroldrubio the download of the attachments works. I just fixed a problem about the naming of attachments.

If we could also download the reviewers, we would be all set :-)

haroldrubio commented 5 months ago

@crux82 When I run the committee script, it appears to list the reviewers in the YML file after the line role: Area Chairs. Is this the case for you or are you running into something else with the reviewers?

crux82 commented 5 months ago

@haroldrubio I am sending you what I downloaded via mail

crux82 commented 4 months ago

@haroldrubio any news?