1: Refactor: Make githooks config variables more consistent :tada:

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control

MIT License

382 stars 20 forks source link

1: Refactor: Make githooks config variables more consistent :tada: #109

Closed gabyx closed 4 years ago

gabyx commented 4 years ago

A small refactor to move global git config variables to make them more consistent.

githooks.autoupdate.updateCloneUrl -> githooks.cloneUrl githooks.autoupdate.updateCloneBranch -> githooks.cloneBranch githooks.previous.searchDir -> githooks.previousSearchDir

See legacy_transformation in install.sh which takes care of transformation and deleting old values.

Thanks for merging =)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 685

36 of 47 (76.6%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 81.542%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cli.sh	9	13	69.23%
install.sh	14	21	66.67%
<!--	Total:	36	47	76.6%	-->

Totals
Change from base Build 679:	-0.1%
Covered Lines:	2094
Relevant Lines:	2568

💛 - Coveralls

gabyx commented 4 years ago

Would be good to go: All tests pass

rycus86 commented 4 years ago

LGTM, one thing to double check before I merge, shouldn't the legacy transformation deal with githooks.previousSearchDir too?

gabyx commented 4 years ago

Thanks, ehm dont know, lets check! Nice catch, shit, jeah of course!

gabyx commented 4 years ago

Updated

rycus86 commented 4 years ago

Thanks!