search

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control
MIT License
380 stars 19 forks source link

Legacy transformation issues #145

Open rycus86 opened 3 years ago

rycus86 commented 3 years ago

@gabyx I've just caught this output from my dev machine:

# installing the newest version into my Git repositories here
...
/home/vadam/.githome/.githooks/release/install.sh: 470: cd: can't cd to /home/vadam/devhome/.githooks/release/.git
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
Finished
! There were legacy transform errors: check stderr
  If you would like to disable auto-updates, run:
    $ git hooks update disable
...

Looks like there's a bit of error handling missing from the legacy transformation code, plus it seems that there's something spamming the output with Finished

Could you possibly have a look if you have some time, please?

gabyx commented 3 years ago

Jeah I noticed this as well: Its the legacy_transform_update_shared_hooks which prints 'Finished' and also it seems you have the hooks installed in the /home/vadam/devhome/.githooks/release/.git was that an artefact where we forgot the --template=/dev/null on the release clone probably. Also we might have bad registered paths in legacy_transform_after_update which comes before we clean it up in install_into_registered_repositories...

gabyx commented 3 years ago

I make a PR.

rycus86 commented 3 years ago

Thanks a lot!