Bugfix: Fix wrong legacy check

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control

MIT License

380 stars 19 forks source link

Bugfix: Fix wrong legacy check #148

Closed gabyx closed 3 years ago

gabyx commented 3 years ago

check variable to be unset

Thx for merging. Small stupid logic error :-)

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 886

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 80.325%

Files with Coverage Reduction	New Missed Lines	%
install.sh	1	67.56%
<!--	Total:	1		-->

Totals
Change from base Build 872:	0.0%
Covered Lines:	2372
Relevant Lines:	2953

💛 - Coveralls

gabyx commented 3 years ago

No still swrong

gabyx commented 3 years ago

In the parameter expansions shown previously, use of the colon in the format shall result in a test for a parameter that is unset or null; omission of the colon shall result in a test for a parameter that is only unset. The following table summarizes the effect of the colon:

so ${aaa+thisisset} is correct.

gabyx commented 3 years ago

Good to merge. Now.