Let the install script continue when --non-interactive is passed and no pre-existing template directory is found

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control

MIT License

382 stars 20 forks source link

Let the install script continue when --non-interactive is passed and no pre-existing template directory is found #20

Closed AlexGoris-Cashforce closed 5 years ago

AlexGoris-Cashforce commented 5 years ago

As requested this has been separated from #19 . I've added a custom template directory to the install script.

By passing --template-dir to the install script, the user can specify which directory should be used for the teomplate directory

Also, when --non-interactive is passed (regardless of the above!) the script will continue with setting a new template directory if it can't find a pre-existing one, either to the directory specified by the user, or to a default directory.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 189

5 of 9 (55.56%) changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 91.46%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
install.sh	5	9	55.56%
<!--	Total:	5	9	55.56%	-->

Files with Coverage Reduction	New Missed Lines	%
cli.sh	3	91.62%
<!--	Total:	3		-->

Totals
Change from base Build 188:	-0.4%
Covered Lines:	1510
Relevant Lines:	1651

💛 - Coveralls

AlexGoris-Cashforce commented 5 years ago

@rycus86 mostly good points, thanks! I'll fix them this afternoon. About the markdown formatting, I'll respond inline on the comments.

rycus86 commented 5 years ago

Thanks a lot @AlexGoris-Cashforce ! It looks great! Could you please just squash these into a single commit and force push, then I'll merge it in. :tada: (if you like you could also remove the whitespace at https://github.com/rycus86/githooks/pull/20/files#diff-3fbb47e318cd8802bd325e7da9aaabe8R2883 that shfmt is screaming about here https://travis-ci.org/rycus86/githooks/jobs/557180717 but I'm happy to fix that one up afterwards)

rycus86 commented 5 years ago

I merged another PR, so you'll need to rebase or merge and resolve the conflicts before squashing too, sorry.

AlexGoris-Cashforce commented 5 years ago

Removed whitespace, rebased on your latest master and squashed all commits. Should be good to go now I think?

rycus86 commented 5 years ago

Thanks a lot @AlexGoris-Cashforce !