Bugfix: Fail on not available shared hook.

[gabyx]

The step-103.sh should be failing. I wrote it because it does not in my setup.

-> Installing shared hooks and then accidentially removing them and making a commit should fail because the hooks are not there.

Solution: Do an update if the hooks are not there, or fail with an error "run git hooks shared update"

[gabyx]

The thing is, a clone of a repo with a .shared file results in

git clone https://git.cyfex.com/cyfex/GitUmstellung.git Test
Cloning into 'Test'...
remote: Enumerating objects: 550, done.
remote: Counting objects: 100% (550/550), done.
remote: Compressing objects: 100% (414/414), done.
remote: Total 550 (delta 306), reused 184 (delta 116) eceiving objects:  67% (369/550), 7.89 MiB
Receiving objects: 100% (550/550), 15.50 MiB | 4.71 MiB/s, done.
Resolving deltas: 100% (306/306), done.
F:/Repositories/Test/.git/hooks/post-checkout: line 425: cd: /c/Users/gabriel.nuetzi/.githooks/shared/*: No such file or directory

Which should not happen, its the same error. The hooks are not there yet and should probably be installed, right?

[coveralls]

Pull Request Test Coverage Report for Build 204

• 40 of 63 (63.49%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.6%) to 91.006%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cli.sh	12	14	85.71%
uninstall.sh	8	12	66.67%
base-template.sh	20	37	54.05%
<!--	Total:	40	63	63.49%	-->

Totals
Change from base Build 200:	-0.6%
Covered Lines:	1538
Relevant Lines:	1690

---

💛 - Coveralls

[gabyx]

There are two things:

• on clone, post-checkout runs which should check if any of the .shared hooks need to be cloned if there is no existing repo in ~/.gitignore/shared/* (maybe make the path a hash of the url??)
• on any invocation of all listed .shared hooks, if there is no corresponding repo in ~/.gitignore/shared/* -> fail!

I think its really good to have a hard fail, if shared hooks are not there, because shit can happen :-) for users which just clone and then commit, or accidentially messed up something...

What do you think?

[gabyx]

I fixed the following things: execute_shared_hooks:

• if a shared hooks $SHARED_ROOT is not there -> fails with an error:

  git commit -a -m "asda"
  ! Failed to execute shared hook: https://server.com/mysuperhooks.git
  Do run:
  $ git hooks shared update

• update_shared_hooks_if_appropriate:
  • Also run the hook for post-checkout (maybe this is expensive but woudl leave it as is) , so cloneing works flawlessly.
  • Added a safety cksum to the NORMALIZED_NAME such that each url is treated really differently. (Avoid stupid overlapping)

[gabyx]

Thanks for reviewing this.

[gabyx]

Thanks for merging this. I think its important as it improves usage and safety.

[rycus86]

Thanks for opening this PR! I'll try to review it as soon as I can this coming week!

[rycus86]

OK, so I fixed up the tests (thanks again for pointing out the bugs) and it's still passing. Can you please try to tell me again what exactly is the problem? Let's start with a failing test case, then work from there, because this PR made some big changes already, and I'm not clear on why it was needed. Thanks!

[rycus86]

I've tried your new test step-103 on latest master and it's working fine if you don't expect it to fail where I don't expect it to fail. :) There's some spam on the output about not finding shared hooks, but otherwise everything works as expected, commits are successful and non-existing hooks are skipped. What did you expect?

[gabyx]

See the changes https://github.com/rycus86/githooks/pull/22/commits/e020127fc0c3e8d10782b34b3520e4d6859e0313

[gabyx]

Thx will look at it this eveninh maybe

Von meinem iPhone gesendet

Am 21.07.2019 um 13:01 schrieb Viktor Adam notifications@github.com:

@rycus86 commented on this pull request.

In tests/step-103.sh:

+if [ "$RESULT" = "" ]; then

• echo "! Expected shared hooks to be installed."
• exit 1 +fi +git commit -m "Test" || exit 1

• +# Remove all shared hooks +git hooks shared purge || exit 1

• +# Clone a new one +echo "Cloning" +cd /tmp || exit 1 +git clone /tmp/test103 test103-clone && cd test103-clone || exit 1

• +# Remove all shared hooks +git hooks shared purge || exit 1 Can you please also add a test that fails on the double purge with the new config option set to true?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[gabyx]

Finally all tests good :-)

[rycus86]

Thanks for this again @gabyx !