search

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control
MIT License
381 stars 20 forks source link

Bugfix: Never store relative search paths. #57

Closed gabyx closed 4 years ago

gabyx commented 4 years ago

Small bugfix. Never store relative search paths. This leads to undefined behavior if sudden updates happen from a hook...

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 421

Totals Coverage Status
Change from base Build 415: 0.0%
Covered Lines: 1720
Relevant Lines: 1975
💛 - Coveralls
gabyx commented 4 years ago

I just thought its a bit critical since, the search-dir is stored, togehter with the automatic update procedure which uses this search-dir alsorts of shit can happen :-) with relative paths, which is applyied directly at the cwd in install.sh. But since realpath is not POSIX I close this Bugfix. The #55 is in favor of this since it does not make use of the search-dir for the update mechanism. But you will still be able to update all of your repos of course, because there is a clear autoupdate registering mechanism...