Feature: Delete detected LFS Hooks

rycus86 / githooks

Githooks: per-repo and global Git hooks with version control

MIT License

382 stars 20 forks source link

Closed gabyx closed 4 years ago

gabyx commented 4 years ago

In favor of #53 This works.

coveralls commented 4 years ago

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cli.sh	18	25	72.0%
<!--	Total:	46	53	86.79%	-->

gabyx commented 4 years ago

I found a better solution:

Ask the user if LFS hook has been detected if he wants to delete it or only disabled and backup to .git/hooks/xxxx.disabled.githooks.
Remember this choice in the settings under githooks.deleteDetectedLFSHooks.
Make a cli entry to reset this choice...

Test is added and probperly testet.

gabyx commented 4 years ago

This finished. Tests should work.

rycus86 commented 4 years ago

This PR also looks great, added some comments for minor things to be addressed.

gabyx commented 4 years ago

Rebased and review changes added.

gabyx commented 4 years ago

Ready to merge. Thanks :-)

rycus86 commented 4 years ago

Ready to merge. Thanks :-)

Hm, this has unresolved comments and also conflicts.

gabyx commented 4 years ago

Ups , mom.

gabyx commented 4 years ago

OK now, rebased.

rycus86 commented 4 years ago

Thanks!

rycus86 commented 4 years ago

Hm, it looks like this build the build on Travis, the new test is failing on almost all Docker images. @gabyx could you have a look please?

gabyx commented 4 years ago

This test 111 is failing now. I fix it. Hm...

gabyx commented 4 years ago

Fixed. It was the grep -E which I dropped.