rycus86 / githooks

Githooks: per-repo and global Git hooks with version control
MIT License
381 stars 20 forks source link

Bugfix core.hooksPath #66

Closed gabyx closed 4 years ago

gabyx commented 4 years ago

There are some really unseen errors in the changes I made. Please have look. Its not obvious. But the path I took, now makes sense. See the annotated comments.

Honestly, not to be unfair, but there are a lot of comments in the code base which are trivially unecessary and only make the code much harder to read: Such things... Would be good to clean those once...

    # Delete the hook templates
    remove_existing_hook_templates "$TARGET_TEMPLATE_DIR"

    # Uninstall all shared hooks
    uninstall_shared_hooks

    # Uninstall all cli
    uninstall_cli

My point: If you choose your function name wisely, there is no need for a comment, which is almost the case everywhere :-)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 466


Changes Missing Coverage Covered Lines Changed/Added Lines %
install.sh 9 12 75.0%
uninstall.sh 3 7 42.86%
<!-- Total: 12 19 63.16% -->
Files with Coverage Reduction New Missed Lines %
base-template.sh 1 79.55%
uninstall.sh 2 77.92%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 462: 0.1%
Covered Lines: 1732
Relevant Lines: 1986

💛 - Coveralls
gabyx commented 4 years ago

Please ignore this PR for now. It needs workd