Closed gabyx closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
install.sh | 9 | 12 | 75.0% | ||
uninstall.sh | 3 | 7 | 42.86% | ||
<!-- | Total: | 12 | 19 | 63.16% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
base-template.sh | 1 | 79.55% | ||
uninstall.sh | 2 | 77.92% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 462: | 0.1% |
Covered Lines: | 1732 |
Relevant Lines: | 1986 |
Please ignore this PR for now. It needs workd
There are some really unseen errors in the changes I made. Please have look. Its not obvious. But the path I took, now makes sense. See the annotated comments.
Honestly, not to be unfair, but there are a lot of comments in the code base which are trivially unecessary and only make the code much harder to read: Such things... Would be good to clean those once...
My point: If you choose your function name wisely, there is no need for a comment, which is almost the case everywhere :-)