Bugfix: Finding git directories.

[gabyx]

To review. Not yet perfect.

GIT_DIR=$(cd "$EXISTING" && GIT_DISCOVERY_ACROSS_FILESYSTEM=0 git rev-parse --git-dir)

needs revisit. Return relative path??

[coveralls]

Pull Request Test Coverage Report for Build 511

• 29 of 35 (82.86%) changed or added relevant lines in 2 files are covered.
• 75 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-2.6%) to 84.236%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
install.sh	16	19	84.21%
uninstall.sh	13	16	81.25%
<!--	Total:	29	35	82.86%	-->

Files with Coverage Reduction	New Missed Lines	%
uninstall.sh	8	79.11%
cli.sh	10	88.72%
install.sh	57	78.09%
<!--	Total:	75		-->

Totals
Change from base Build 506:	-2.6%
Covered Lines:	1897
Relevant Lines:	2252

---

💛 - Coveralls

[rycus86]

Do we have any other is_git_dir checks anywhere? Might be good to keep them consistent and doing the same thing.

[rycus86]

Thanks a lot for looking into this btw!

[gabyx]

Please see the changes now.

Btw: Would it make sense to collaborate all copy&paste functions into a general.sh which we also inject during commiting. so we only need to fix bugs once, would you mind refactoring this? Would help in the future.

[rycus86]

Changes look good, just waiting for Travis then I'll merge it.

I'll think about the shared snippet to insert, it's not only a good way to share code but also to share bloat that some scripts wouldn't have needed otherwise. 🙂

[gabyx]

Do we have any other is_git_dir checks anywhere? Might be good to keep them consistent and doing the same thing.

we only have is_git_repo tests and these are ok I think. Other git_dir checks I dont know

[gabyx]

I have not tested it locally on my machine :-) (on windows, unfortunately.) If it does not work, I check tonight...