Closed gabyx closed 4 years ago
Totals | |
---|---|
Change from base Build 630: | 0.0% |
Covered Lines: | 2068 |
Relevant Lines: | 2470 |
Thanks for this! Is this a problem you've seen? We have a whitespace test on Travis, I thought that should have picked it up already?
Jeah on windows. We have these tests, but unfortunately not inside the ~
home folder...
had this on windows...
May be we could use
cat <<EOF | docker build --force-rm -t githooks:whitespaces-base -
FROM alpine
RUN apk add --no-cache git curl ca-certificates
RUN mkdir -p "/root/whitespace folder"
ENV HOME="/root/whitespace folder"
EOF
That seems to work and fail the whitespace tests...
I like your suggestion, we should try that. Travis seems to be OK with this change on Linux, so let me merge it.
I have some more test changes ;-) in test-whitespace.sh
Will open this in another PR, this will propery test this PR.
to what will ~
expand if it has whitespace inside?
We should prohibit install into a ~
which has whitespaces. It just gives lots of troubles...
or can we really handle this properly ?
or we should replace every ~
with a proper $HOME
ok: I see https://unix.stackexchange.com/a/151852/63957
that tilde expansion is a single word hm...
Thx for merging