search

rydurham / L4withSentry

Laravel 4 and Sentry 2.0
300 stars 91 forks source link

Bulgarian Translation Added and Some Tests #63

Closed melanholly closed 10 years ago

melanholly commented 10 years ago

Hello, This is my first real use of GitHub.

I've Added Bulgarian translation to the lang folder. I have Edited files in the view directory. For some reason home.blade.php is not he one that I have used on my machine? I have fixed some bugs in the tests files.

Best Regards Kiril Grancharov

rydurham commented 10 years ago

This is great - thank you! For now, can you separate your BG language files and your edits to the views into two different pull requests?

The views in this repo do need to be made more translation friendly, and for the most part these changes look good, however there are a few different places where I think we should make some tweaks before we merger them into the repo.

As a separate note, would you be willing to make a set of BG language files for my Sentinel package? It is essentially the same codebase as this repo, and the language strings are very similar (though not identical.)

Thanks!

rydurham commented 10 years ago

You might as well make your changes to the tests into a third pull request as well. Thanks!

melanholly commented 10 years ago

Ok I'll make three requests but later this week because currently I am in a middle of holiday and I don't have much time ot my Linux-PC.