rydurham / Sentinel

A Sentry bridge package for Laravel
http://www.ryandurham.com/projects/sentinel/
317 stars 68 forks source link

resend activation email if user is already registered #208

Closed tusharvikky closed 8 years ago

tusharvikky commented 8 years ago

Hello,

If the user is already registered and he hasn't activated the account. Can we just resend the activation mail again if he submits login or registration form?

rydurham commented 8 years ago

Currently a user will be prompted with the option to resend their activation email if they attempt to log in without having activated their account.

https://github.com/rydurham/Sentinel/blob/master/src/Sentinel/Repositories/Session/SentrySessionRepository.php#L98

tusharvikky commented 8 years ago

Yes. True. Re-sending account activation email would be a good idea if the user hasn't yet activated. When he or she tries to register/login again with inactive account email.

Also, while account activation email is sent via /reactivate, if the user enters invalid email id we should return with Account not found instead of success (check email) message.

https://github.com/rydurham/Sentinel/blob/master/src/Sentinel/Repositories/User/SentryUserRepository.php#L258

rydurham commented 8 years ago

I am open to a pull request if you are interested.

tusharvikky commented 8 years ago

I'm on ~v2.2. No update yet. :(

rydurham commented 8 years ago

I haven't tagged a new version yet.

On Jun 30 2016, at 1:23 pm, Tushar Deo <notifications@github.com> wrote:

I'm on ~v2.2. No update yet. :(


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

tusharvikky commented 8 years ago

Could you please tag a v2.2.6 with this commit?

rydurham commented 8 years ago

I just tagged v2.2.6 - sorry that took so long. You may want to double check that everything is working as intended.

tusharvikky commented 8 years ago

Seems to have an issue with line https://github.com/rydurham/Sentinel/blob/ef862ede26d510fc4181d6583c707ec38ff09222/src/Sentinel/Repositories/User/SentryUserRepository.php#L275 and L303 being interchanged.

rydurham commented 8 years ago

Good catch! That is now fixed in v2.2.7.