Open westonruter opened 6 years ago
I was trying to do npm run dev but the webpack build would fail due to eslint errors (see below).
npm run dev
So this PR fixes the issues so that webpack can do the build.
js/components/attachment/index.jsx:60:13: Missing radix parameter. [Error/radix] js/components/author/index.jsx:46:40: No magic number: 1. [Error/no-magic-numbers] js/components/author/list.jsx:35:20: No magic number: 1. [Error/no-magic-numbers] js/components/author/list.jsx:40:2: Unnecessary semicolon. [Error/no-extra-semi] js/components/author/list.jsx:57:9: Missing radix parameter. [Error/radix] js/components/comments/form.jsx:69:15: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/form.jsx:76:7: No magic number: 5000. [Error/no-magic-numbers] js/components/comments/form.jsx:170:18: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/index.jsx:42:19: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/index.jsx:48:27: No magic number: 1. [Error/no-magic-numbers] js/components/comments/index.jsx:55:44: use `Boolean(this.props.total)` instead. [Error/no-implicit-coercion] js/components/comments/index.jsx:56:7: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/single.jsx:18:24: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/single.jsx:32:9: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/comments/single.jsx:46:8: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/date/index.jsx:41:20: No magic number: 1. [Error/no-magic-numbers] js/components/date/index.jsx:59:40: No magic number: 1. [Error/no-magic-numbers] js/components/date/index.jsx:64:28: No magic number: 1. [Error/no-magic-numbers] js/components/date/index.jsx:69:28: No magic number: 1. [Error/no-magic-numbers] js/components/date/index.jsx:74:28: No magic number: 1. [Error/no-magic-numbers] js/components/date/index.jsx:90:9: Missing radix parameter. [Error/radix] js/components/navigation/index.jsx:18:9: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/navigation/index.jsx:71:33: No magic number: 1. [Error/no-magic-numbers] js/components/navigation/index.jsx:92:58: use `Boolean(this.state.isMenuOpen)` instead. [Error/no-implicit-coercion] js/components/navigation/index.jsx:94:51: use `Boolean(this.state.isMenuOpen)` instead. [Error/no-implicit-coercion] js/components/pagination/archive.jsx:12:10: Missing radix parameter. [Error/radix] js/components/pagination/archive.jsx:12:43: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/archive.jsx:13:10: Missing radix parameter. [Error/radix] js/components/pagination/archive.jsx:13:43: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/comments.jsx:24:35: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/comments.jsx:25:35: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/comments.jsx:30:8: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/pagination/comments.jsx:36:8: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/pagination/test/index.js:16:65: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/test/index.js:17:61: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/test/index.js:23:61: No magic number: 1. [Error/no-magic-numbers] js/components/pagination/test/index.js:28:65: No magic number: 1. [Error/no-magic-numbers] js/components/placeholder/index.jsx:8:25: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/placeholder/index.jsx:12:25: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/placeholder/index.jsx:16:25: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/image.jsx:14:3: Expected a default case. [Error/default-case] js/components/post/image.jsx:16:20: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/index.jsx:75:8: use `Boolean(this.props.previewId)` instead. [Error/no-implicit-coercion] js/components/post/index.jsx:75:9: Redundant double negation. [Error/no-extra-boolean-cast] js/components/post/index.jsx:99:31: Missing radix parameter. [Error/radix] js/components/post/meta.jsx:11:10: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/meta.jsx:11:12: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/meta.jsx:11:46: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/meta.jsx:11:84: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/post/page.jsx:71:8: use `Boolean(this.props.previewId)` instead. [Error/no-implicit-coercion] js/components/post/page.jsx:71:9: Redundant double negation. [Error/no-extra-boolean-cast] js/components/post/page.jsx:94:35: No magic number: 1. [Error/no-magic-numbers] js/components/post/page.jsx:100:31: Missing radix parameter. [Error/radix] js/components/posts/index.jsx:22:8: use `Boolean(this.props.previewId)` instead. [Error/no-implicit-coercion] js/components/posts/index.jsx:22:9: Redundant double negation. [Error/no-extra-boolean-cast] js/components/posts/index.jsx:48:20: No magic number: 1. [Error/no-magic-numbers] js/components/posts/index.jsx:58:40: No magic number: 1. [Error/no-magic-numbers] js/components/posts/index.jsx:72:9: Missing radix parameter. [Error/radix] js/components/posts/sticky.jsx:28:2: Unnecessary semicolon. [Error/no-extra-semi] js/components/posts/test/fixtures/store.js:36:35: No magic number: 1. [Error/no-magic-numbers] js/components/posts/test/fixtures/store.js:36:38: No magic number: 2. [Error/no-magic-numbers] js/components/posts/test/index.js:28:44: No magic number: 1. [Error/no-magic-numbers] js/components/posts/test/index.js:32:61: No magic number: 2. [Error/no-magic-numbers] js/components/search/index.jsx:61:40: No magic number: 1. [Error/no-magic-numbers] js/components/search/index.jsx:67:9: Missing radix parameter. [Error/radix] js/components/term/index.jsx:48:40: No magic number: 1. [Error/no-magic-numbers] js/components/term/list.jsx:35:20: No magic number: 1. [Error/no-magic-numbers] js/components/term/list.jsx:40:2: Unnecessary semicolon. [Error/no-extra-semi] js/components/term/list.jsx:45:10: Gratuitous parentheses around expression. [Error/no-extra-parens] js/components/term/list.jsx:57:9: Missing radix parameter. [Error/radix] js/customize-preview.js:24:24: Gratuitous parentheses around expression. [Error/no-extra-parens] js/customize-preview.js:24:65: No magic number: 1. [Error/no-magic-numbers] js/index.jsx:60:17: Gratuitous parentheses around expression. [Error/no-extra-parens] js/index.jsx:86:3: Gratuitous parentheses around expression. [Error/no-extra-parens] js/index.jsx:96:4: Gratuitous parentheses around expression. [Error/no-extra-parens] js/index.jsx:156:51: No magic number: 1. [Error/no-magic-numbers] js/index.jsx:157:63: No magic number: 1. [Error/no-magic-numbers] js/index.jsx:198:34: No magic number: 1. [Error/no-magic-numbers] js/utils/a11y.js:34:44: Gratuitous parentheses around expression. [Error/no-extra-parens] js/utils/a11y.js:43:2: Unnecessary semicolon. [Error/no-extra-semi] js/utils/a11y.js:52:64: No magic number: 1. [Error/no-magic-numbers] js/utils/a11y.js:53:9: Gratuitous parentheses around expression. [Error/no-extra-parens] js/utils/a11y.js:59:9: Gratuitous parentheses around expression. [Error/no-extra-parens] js/utils/a11y.js:72:6: Designated alias 'self' is not assigned to 'this'. [Error/consistent-this] js/utils/a11y.js:85:3: Designated alias 'self' is not assigned to 'this'. [Error/consistent-this] js/utils/content-mixin.js:47:11: Gratuitous parentheses around expression. [Error/no-extra-parens] test/runner.js:39:6: Unexpected use of process.env. [Error/no-process-env] test/runner.js:43:23: No magic number: 10000. [Error/no-magic-numbers] test/runner.js:46:48: Unexpected use of process.env. [Error/no-process-env] test/runner.js:49:30: Unexpected use of process.env. [Error/no-process-env] test/runner.js:52:91: Unexpected use of process.env. [Error/no-process-env] test/runner.js:74:26: No magic number: 1. [Error/no-magic-numbers] webpack.config.js:3:16: Unexpected use of process.env. [Error/no-process-env] webpack.config.js:30:11: Gratuitous parentheses around expression. [Error/no-extra-parens] webpack.config.js:31:9: Gratuitous parentheses around expression. [Error/no-extra-parens] webpack.config.js:31:41: Unnecessary use of boolean literals in conditional expression. [Error/no-unneeded-ternary] zip-theme.js:12:32: No magic number: 1. [Error/no-magic-numbers] 97 problems
I was trying to do
npm run devbut the webpack build would fail due to eslint errors (see below).So this PR fixes the issues so that webpack can do the build.