ryenl / pe

0 stars 0 forks source link

No limit for the email field when adding a person #7

Open ryenl opened 1 week ago

ryenl commented 1 week ago

Very unlikely to occur in real use but thought it would be notable. Adding a person with an unnaturally long email can cause the email to overflow in the UI

Steps to reproduce: adding a person where the field e/51345431512435...@gmail.com is unnaturally long. where ... is a long chain of random numbers

Screenshot 2024-11-15 at 4.52.20 PM.png

soc-se-bot commented 4 days ago

Team's Response

Thanks for raising this issue. Agreed that email should have a maximum length to prevent this issue from occuring. However, this should be a feature flaw instead since according to the UG, there is no length restrictions for email. We also think the severity should be Very Low as this is a cosmetic issue. All commands use the student's matriculation number, and not email, so the user will not need to know the student's email. The user also does not need to know the student's email when editing the student's email, as the new email will overwrite the old email.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]