search

ryentes / careless

Other
25 stars 8 forks source link

psychsyn_critval output label #32

Closed awmeade closed 3 years ago

awmeade commented 3 years ago

The output from psychsyn_critival is great, but the observed correlation in the output is labelled as "Freq". Consider changing to something like "correlation" or "cor"

awmeade commented 3 years ago

actually, i should have made this "cor" instead of "correlation" to be consistent with the output from psychsyn

ryentes commented 3 years ago

So we ended up changing the label to "cor" which is consistent with other packages (i.e. stats, psych) and the output of the psychsyn function if diag = TRUE. That said, I'm not opposed to revisiting the naming of a variety of our outputs to ease the experience of users who are not familiar and/or comfortable in R. I think that's part of a larger discussion though.