search

ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.
https://sa11y.netlify.app
Other
280 stars 43 forks source link

css important #17

Closed brianteeman closed 3 years ago

brianteeman commented 3 years ago

now that all the css is much more specific does it really still need the !important

adamchaboryk commented 3 years ago

I know it's overkill in some places, although I guess it's there for redundancy (lol). It's just a bulletproof way of ensuring there's no conflicts across every website. From my testing, the all: unset; hack doesn't capture everything.

It would require a considerable amount of time to test which elements don't require !important (across various websites).

Any reasons to remove the many instances of !important?

brianteeman commented 3 years ago

In general I believe it to be bad practice and can lead to further problems in the future but I guess for a utility like this its probably ok and not worth investing the time to check