search

ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.
https://sa11y.netlify.app
Other
280 stars 43 forks source link

Link check (advanced) #25

Closed brianteeman closed 2 years ago

brianteeman commented 2 years ago

@adamchaboryk Re the change you made to advanced links

Need a surrounding if (linkText !== null), otherwise empty links get both a warning and error flag.

I dont think that goes far enough. If you have an empty link but it has target=_blank you will still get a warning and an error.

https://github.com/ryersondmp/sa11y/blob/1931c3b2a67f2e76f64bcd1279b503f17763d0fc/docs/examples/links-tables.html#L116-L117

However I am not sure what the problem is that you were trying to solve originally.

adamchaboryk commented 2 years ago

Thanks @brianteeman

Yes, indeed doesn't go far enough. Although I think that's a very, very specific use case (empty link + target blank)...

I was originally trying to fix:

<a href="https://www.google.com"></a>
<a href="https://www.bing.com"></a>

Which would show following screenshot:

Screenshot of Sa11y flagging an empty hyperlink warning that it has same link text as another in addition to overlapping error flag.
brianteeman commented 2 years ago

yeah well I was trying to work out what the bug was you were fixing.