ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.
https://sa11y.netlify.app
Other
284 stars 44 forks source link

booklet #76

Closed brianteeman closed 8 months ago

brianteeman commented 8 months ago

Don't know if these are possible but I thought I should ask.

  1. I find that after clicking on the booklet to turn it on I am then clicking on it again to try and turn it off and of course get the message "Sa11y is already loaded on this page. Please wait, or reload the page and try again." Would it be possible to have a it work the way my brian is working and have the second click simply turn off sally.

  2. On pages where the booklet wont work eg here at github because of the csp is it possible to display an alert. Otherwise someone might just think sa11y doesnt work at all.

adamchaboryk commented 8 months ago

Hmm, this is great feedback. Thanks again @brianteeman!

1 should be doable, I'll look into it.

As for 2, I did a little research. I thought this was impossible initially, but it looks like WebAim figured it out with their contrast bookmarklet!

TIL there's an event for securitypolicyviolation.

Adding this to the to-do list!

brianteeman commented 8 months ago

Thats great news.

brianteeman commented 8 months ago

awesome stuff -- love it!!

adamchaboryk commented 8 months ago

Shipped! TY once again for the great feedback, @brianteeman. I also tinkered with the language files, so it injects the right locale based on page lang. One less thing to include in build step, and better UX for all.