search

rylandg / myos

Develop and share terminal environments
https://www.cdevn.com/my-os/
MIT License
142 stars 10 forks source link

Script does not work in Ubuntu #13

Closed marcopiraccini closed 5 years ago

marcopiraccini commented 5 years ago

Describe the bug When running in Ubutntu, myos.sh does not work:

⇒ ./myos.sh init
/bin/sh: 0: Illegal option -

The reason is probably that in ubuntu /bin/sh is a link to dash:

⇒ ls -lah /bin/sh
lrwxrwxrwx 1 root root 4 gen 14 11:37 /bin/sh -> dash*

One solution would be to use bash in the script or adapt the script to work also with dash

To Reproduce Just run in Ubuntu 19.04 should be the same in other versions)

Expected behavior It should not exit immediately :)

Host OS (please complete if relevant):

tokelove commented 5 years ago

I can reproduce this on Ubuntu 18.04

rylandg commented 5 years ago

Will fix today. It’s actually just a single character messing it up.

Thanks a ton for making an issue and trying out the project, sorry it didn’t work out of the box.

rylandg commented 5 years ago

Should be fixed by https://github.com/rylandg/myos/pull/14 please let me know!

marcopiraccini commented 5 years ago

It's fixed, tnx :)