search

rylandg / myos

Develop and share terminal environments
https://www.cdevn.com/my-os/
MIT License
142 stars 10 forks source link

Fail to run the container, with docker-compose version 3.7 #27

Closed muniter closed 5 years ago

muniter commented 5 years ago

Describe the bug myos create rysenv fails because the generated docker-compose file is not supported by docker-compose. myos.sh generates version: "3.7".

To Reproduce Follow the installation steps until you get to $ myos create rysenv then the problem arises

Expected behavior The container runs succesfully

Host OS:

Additional context Fixed it by changing version: "3.7" by version: "3" and then running docker-compose up -d and renaming the container for what myos.sh was looking for docker container rename mayosconfig_myos_1 rysenv_myos_1

rylandg commented 5 years ago

Hey, thanks for opening the issue. Just to help me understand, could this be solved by updating docker-compose runtime? We don't exactly "generate" a docker-compose.yml file, it's just a template. Maybe we can get away with a much lower version, let me look into it.

rylandg commented 5 years ago

@all-contributors please add @muniter for finding bugs

allcontributors[bot] commented 5 years ago

@rylandg

I've put up a pull request to add @muniter! :tada:

muniter commented 5 years ago

Hey, you're welcome, glad to be of help.

Maybe we can get away with a much lower version, let me look into it.

From what I've just read seems like yeah, we can manage by running a much lower docker-compose file version. Just looking at the file is pretty simple, and version 3 supports all the features being used.

The following article the differences in version 3.x are named, none should affect what's being used. I think is a better idea to set it to version 3 and have a wider scope. Ubuntu 18.04 is one of the must run distro in developers that run Linux I would imagine. So supporting them out of the box would be great.

rylandg commented 5 years ago

Sounds 100% logical. Want to make the PR or should I?

On Sun, Jun 16, 2019 at 10:58 AM Javier Lopez notifications@github.com wrote:

Hey, you're welcome, glad to be of help.

Maybe we can get away with a much lower version, let me look into it.

From what I've just read seems like yeah, we can manage by running a much lower docker-compose file version. Just looking at the file is pretty simple, and version 3 supports all the features being used.

The following article https://docs.docker.com/compose/compose-file/compose-versioning/#version-3 the differences in version 3.x are named, none should affect what's being used. I think is a better idea to set it to version 3 and have a wider scope. Ubuntu 18.04 is one of the must run distro in developers that run Linux I would imagine. So supporting them out of the box would be great.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rylandg/myos/issues/27?email_source=notifications&email_token=AGTTQOX6IBGHUPNIENQDKYTP2Z5N7A5CNFSM4HYQHCB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZSA6Q#issuecomment-502472826, or mute the thread https://github.com/notifications/unsubscribe-auth/AGTTQOVCMOEU2K6VBU5ZNHDP2Z5N7ANCNFSM4HYQHCBQ .

muniter commented 5 years ago

@rylandg Great! go ahead with the PR. I'm just getting started with git, don't know how to do a PR yet :D. And a little busy today.

Just a geek from an unrelated profession getting into linux, programming, docker, etc.

muniter commented 5 years ago

Oh I managed to do It using the gui nvm. PR submitted #32