search

rylandg / myos

Develop and share terminal environments
https://www.cdevn.com/my-os/
MIT License
142 stars 10 forks source link

No feedback/error when repo is missing #8

Closed wrenchpilot closed 5 years ago

wrenchpilot commented 5 years ago

No feedback/error when repo is missing myos create foo does not return an error or fail if the repo is missing. It just runs forever. Running docker-compose up -d by hand returns:

Pulling myos (myos:latest)... ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing.

Continue with the new image? [yN]y Pulling myos (myos:latest)... ERROR: pull access denied for myos, repository does not exist or may require 'docker login'

To Reproduce Steps to reproduce the behavior:

  1. install myos via npm
  2. init the template
  3. run myos create foo
  4. the command will run until interrupted. I let it run for over an hour before I killed it.

Host OS (please complete if relevant):

wrenchpilot commented 5 years ago

Was able to get past this by editing the docker-compose.yml file and changing the image from: image: 'myos:${TAG:-latest}'

to

image: 'rylandg/myos'

rylandg commented 5 years ago

Awesome feedback. Definitely an issue. Short term I will simply put out a patch that relies on the remote image.

wrenchpilot commented 5 years ago

Awesome project, if I catch a break I'll see if I can submit some pulls for other editors etc 🙏

rylandg commented 5 years ago

Would definitely appreciate it. I prefer code reviews always, when possible. If you have a moment, check this out https://github.com/rylandg/myos/pull/9. If you check it real quick, i'll merge it in a few.

rylandg commented 5 years ago

Fixed in https://github.com/rylandg/myos/pull/9