yukinchan commented 5 years ago

These configuration need to be read and set from metadash.settings but not from environment variables. This reverts commit e1c3e97cd2ab75ba28376062fe942fab199cedc0.

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will decrease coverage by 0.04%. The diff coverage is 40%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   73.43%   73.39%   -0.05%     
==========================================
  Files          51       51              
  Lines        1984     1981       -3     
==========================================
- Hits         1457     1454       -3     
  Misses        527      527

Impacted Files	Coverage Δ
metadash/settings.py	`77.46% <ø> (-0.92%)`	:arrow_down:
metadash/utils/khelper.py	`42.85% <33.33%> (ø)`	:arrow_up:
metadash/auth/ldap.py	`45% <50%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7517ad...83b9d18. Read the comment docs.

ryncsn commented 5 years ago

Thanks, I didn't test these when merging previous PR, will see if should add some unit test to cover such case.

ryncsn / metadash

Revert "Fix runtime errors since config has been moved to settings" #24

Codecov Report