rynlwhh / pe

0 stars 0 forks source link

Changing json file #11

Open rynlwhh opened 6 days ago

rynlwhh commented 6 days ago

I changed the json file to have incorrect inputs like name having symbols when suppose to be alphanumeric but the app still displays the old one this goes against the UG and DG

nus-pe-bot commented 3 days ago

Team's Response

Thank you for your bug report. We acknowledge that PROperty does not have any checks for invalid JSON edits. However, we have also stated explicitly in the User Guide, as seen in the screenshot below, that modifying the data file with edits that are invalid may cause PROperty to behave unexpectedly, and we strongly discourage this.

We have also downgraded the severity to Low since most users will not be editing the JSON file at all under normal usage. It is much easier to use the application to edit names than accessing the JSON file.

Screenshot 2024-11-18 140225.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I agree with the change in severity level but I feel that the UG should explain what to do if the json file was edited and not just state what might happen, as if the json file was edited the user might not know what to do. Perhaps can add an extra line about how use the backup json file before editing if there is an error after editing the json file?


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]