search

rynlwhh / pe

0 stars 0 forks source link

Edit command UI feedback misleading #7

Open rynlwhh opened 1 week ago

rynlwhh commented 1 week ago

When I use the edit command, and try to delete the tag of a certain client that does not have a tag the UG says it should do nothing but the UI says that it edited the client, it can be misleading to users, as they may think they actually deleted a tag when they did not.

Suggestion: UI should show something like Nothing happened or it should just not work.

Screenshot 2024-11-15 at 4.54.18 PM.png

Screenshot 2024-11-15 at 4.54.23 PM.png

Screenshot 2024-11-15 at 4.55.45 PM.png

nus-se-script commented 3 days ago

Team's Response

Thank you for your bug report. However, we believe that this issue is Not In Scope. We acknowledge that the update message could have been clearer and explicitly state that no updates were made to the contact and is definitely something good to have in the future.

However, we also explicitly stated that “if you specify a tag that does not exist, it will do nothing”, which PROperty holds true to the UG (see the 2nd sub bullet of the 6th bullet point of your screenshot). And true to the UG, after you keyed in edit 7 dt/seller, nothing happened to the data of the client, albeit PROperty showing a slightly misleading update message. Hence, we concluded that this issue is Not In Scope.

Additionally, doing such edits that you have raised does not affect normal usage of PROperty at all, as no client data is altered. As such, we decided also that the low severity would be more appropriate for this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As the team stated, "We acknowledge that the update message could have been clearer and explicitly state that no updates were made to the contact", so this is a functionality bug as "Behavior is not specified and differs from normal expectations" so the UI message should give a nothing happened or not valid tag, not that it edited the client cause that is not what happened.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. severity.Medium : A flaw that causes occasional inconvenience to some users, but they can continue to use the product. According to the definition given in the course website I feel it should be severity medium as the edit command will be used frequently. Even though the data is not altered which show they can still use the product, it can still cause inconvenience to the user as the UI message can be very misleading and confusing to the user.