search

rynop / dynamodb-local

A wrapper for AWS DynamoDB Local, intended for use in testcases
MIT License
51 stars 30 forks source link

workaround around a syntax mystery #25

Closed mandrewes closed 5 years ago

mandrewes commented 5 years ago

Hi,

I've joined a new company with node projects and when I've included dynamodb-local as a dependency I receive an ReferenceError on this line.

I'm not sure why this error crops up, but it does and this fixes it. I've raised as a patch as if it's happening in the projects I've come on to, it may be happening to others.

ReferenceError: debug is not defined 1 | 'use strict' 2 |

3 | const DynamoDbLocal = require('dynamodb-local'); 4 | const dynamoLocalPort = 8000; 5 | at Object. (node_modules/dynamodb-local/index.js:12:11) at Object. (test/unit-tests/libs/health-check-unit-test.js:3:23)

mandrewes commented 5 years ago

Hey @rynop - could you take a look at this and let me know whether you will merge or not?

regs Michael

rynop commented 5 years ago

@fishcharlie , @vladgolubev: are either of you seeing this issue? I'm hesitant to mess with this section given the regression that was introduced around it.

@mandrewes what ver of node you using, and can you give an example of how you are using dynamodb-local?

vladholubiev commented 5 years ago

@rynop we're using the latest 0.0.24 and all the tests are passing just fine.

We're using Node 8 to run the tests. What version do you use @mandrewes ?

fishcharlie commented 5 years ago

@rynop This was the problem I was seeing on a previous version. But the latest version is working perfectly for us now.

@mandrews I would make sure you have updated to the latest version of this package (0.0.24). It was fixed in that version.

mandrewes commented 5 years ago

0.0.24 works like a charm thanks.