search

rynorris / nes

NES emulator written in Rust
MIT License
11 stars 0 forks source link

Fix DMC samples never actually playing #32

Closed rynorris closed 5 years ago

rynorris commented 5 years ago

Fixes #22

Big facepalm here. Turns out the other drums are actually played by the noise channel, and my DMC channel was just totally broken.

codecov-io commented 5 years ago

Codecov Report

Merging #32 into master will increase coverage by 0.03%. The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   94.78%   94.82%   +0.03%     
==========================================
  Files          42       42              
  Lines        5276     5561     +285     
==========================================
+ Hits         5001     5273     +272     
- Misses        275      288      +13
Impacted Files Coverage Δ
src/emulator/apu/synth.rs 76.53% <25%> (-1.64%) :arrow_down:
src/emulator/apu/mod.rs 92.78% <66.66%> (-0.81%) :arrow_down:
src/emulator/io/sdl.rs 30.76% <0%> (-9.24%) :arrow_down:
src/emulator/ppu/registers.rs 48.07% <0%> (-6.98%) :arrow_down:
src/emulator/cpu/addressing.rs 97.36% <0%> (-2.64%) :arrow_down:
src/emulator/clock.rs 97.94% <0%> (-2.06%) :arrow_down:
src/emulator/mod.rs 83.67% <0%> (-0.87%) :arrow_down:
src/emulator/cpu/test/nestest.rs 83.33% <0%> (-0.71%) :arrow_down:
src/emulator/io/palette.rs 100% <0%> (ø) :arrow_up:
src/emulator/ppu/test/background.rs 100% <0%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcccda6...2dd7fd5. Read the comment docs.