search

rynorris / nes

NES emulator written in Rust
MIT License
11 stars 0 forks source link

Implement CNROM Mapper #35

Closed rynorris closed 6 years ago

rynorris commented 6 years ago

iNES mapper number 3.

Tested with Arkanoid and Tetris. Found that I'd missed implementing the IRQ inhibit flag in the APU, which causes Arkanoid to crash at boot if not respected.

codecov-io commented 6 years ago

Codecov Report

Merging #35 into master will increase coverage by 0.17%. The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   95.17%   95.35%   +0.17%     
==========================================
  Files          42       44       +2     
  Lines        5601     5624      +23     
==========================================
+ Hits         5331     5363      +32     
+ Misses        270      261       -9
Impacted Files Coverage Δ
src/emulator/mappers/mmc1.rs 87.71% <ø> (ø)
src/emulator/mappers/cnrom.rs 0% <0%> (ø)
src/emulator/mod.rs 81.9% <0%> (+0.77%) :arrow_up:
src/emulator/apu/mod.rs 94.69% <100%> (+1.91%) :arrow_up:
src/emulator/mappers/nrom.rs 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c6cc8d...e3658c7. Read the comment docs.