search

rynorris / nes

NES emulator written in Rust
MIT License
11 stars 0 forks source link

Small refactor to gain access to all key components at top level #51

Closed rynorris closed 5 years ago

rynorris commented 5 years ago

Wrap the various RAM modules in Rc<RefCell<>> so we can keep a reference to them at top level. Going to be necessary for save-states.

I expected this to be a small drop in performance, but testing appears to show it's actually a slight gain. I have no idea why.

codecov[bot] commented 5 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   90.99%   91.01%   +0.02%     
==========================================
  Files          50       50              
  Lines        3210     2939     -271     
==========================================
- Hits         2921     2675     -246     
+ Misses        289      264      -25
Impacted Files Coverage Δ
src/emulator/mod.rs 88.09% <100%> (+5.9%) :arrow_up:
src/emulator/cpu/mod.rs 78.68% <0%> (-6.16%) :arrow_down:
src/emulator/test/mod.rs 86.53% <0%> (-4.26%) :arrow_down:
src/emulator/memory.rs 81.15% <0%> (-1.45%) :arrow_down:
src/emulator/ppu/mod.rs 97.82% <0%> (-0.24%) :arrow_down:
src/emulator/ppu/registers.rs 73.8% <0%> (+2.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea3a52e...eee9622. Read the comment docs.