search

rynorris / nes

NES emulator written in Rust
MIT License
11 stars 0 forks source link

Adjust audio buffering strategy #56

Closed rynorris closed 5 years ago

rynorris commented 5 years ago

Now we downsample audio based on the number of elapsed cycles. This causes the audio to degrade (slightly) more gracefully when performance drops. Instead of wildly changing pitch, it will stutter, which I think is slightly nicer.

Note: we have to pass through these values into the emulator code instead of just assuming them in order to still get the pitch-bending quality when adjusting the emulation speed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          54       54           
  Lines        3267     3267           
=======================================
  Hits         3048     3048           
  Misses        219      219
Impacted Files Coverage Δ
src/emulator/io/mod.rs 100% <ø> (ø) :arrow_up:
src/emulator/mod.rs 93.44% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 219b2fa...34d55fb. Read the comment docs.