search

rynorris / nes

NES emulator written in Rust
MIT License
11 stars 0 forks source link

Remove odd frame cycles #58

Closed rynorris closed 5 years ago

rynorris commented 5 years ago

This was causing indiana jones to be broken again. So this is clearly not the right way to implement even/odd frame timings. (or some other timing thing is off)

Just removing the even/odd ppu timings for now and can re-evaluate later.

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   93.29%   93.27%   -0.03%     
==========================================
  Files          54       54              
  Lines        3267     3255      -12     
==========================================
- Hits         3048     3036      -12     
  Misses        219      219
Impacted Files Coverage Δ
src/emulator/state.rs 0% <ø> (ø) :arrow_up:
src/emulator/ppu/mod.rs 97.32% <ø> (-0.06%) :arrow_down:
src/emulator/ppu/state.rs 100% <ø> (ø) :arrow_up:
src/emulator/test/ppu_sprite_hit.rs 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87d8f3a...70fe659. Read the comment docs.