search

ryo-ma / deno-websocket

🦕 A simple WebSocket library like ws of node.js library for deno
https://deno.land/x/websocket
MIT License
152 stars 19 forks source link

You should pass the url into the connection event handler #17

Closed crankywilson closed 3 years ago

crankywilson commented 3 years ago

I modified connect() in WebSocketServer so that it does this: this.emit("connection", ws, req.url); (added the extra param)

this is standard behavior in other webscoket (server) implementations and this data seems completely unreachable in the user code otherwise...

UserJHansen commented 3 years ago

This looks like it's good to close now