search

ryo-ma / deno-websocket

🦕 A simple WebSocket library like ws of node.js library for deno
https://deno.land/x/websocket
MIT License
152 stars 19 forks source link

Improve typings for EventEmitter-related api #34

Closed Danielduel closed 2 years ago

Danielduel commented 2 years ago

Opening this PR to open discussion about this topic. If this change is welcome - I want to do very similar types for WebSocketClient/WebSocketAcceptedClient "on".

Danielduel commented 2 years ago

Ready for review, I've added (unplanned) typings for "emit" (it felt like low-hanging fruit)

// I would squash-merge it as "Improve typings for EventEmitter-related api", but it is optional

ryo-ma commented 2 years ago

LGTM!