ryo-ma / github-profile-trophy

🏆 Add dynamically generated GitHub Stat Trophies on your readme
https://github-profile-trophy.vercel.app
MIT License
5.3k stars 791 forks source link

Feature Request: Customisable Trophy Size and Spacing #254

Closed yihong1120 closed 10 months ago

yihong1120 commented 11 months ago

Description

Hello there,

I've been using the GitHub Profile Trophy on my profile, and it's a fantastic way to showcase achievements in a visually appealing manner. I appreciate the work that has gone into creating this project.

Suggestion

However, I've noticed that while we can control the margin width and height between trophies, we currently don't have the option to adjust the size of the trophies themselves or the spacing directly around each individual trophy. I believe adding this feature would provide an even greater level of customisation for users who may want to fit the trophies into a specific layout on their profiles.

Implementation

Ideally, it would be great to have additional query parameters such as trophy-size and trophy-spacing that allow for fine-tuning of the trophy display. This could help with creating a more tailored look and feel for the trophies on different types of GitHub profile READMEs.

Conclusion

Thank you for considering this feature request. I'm looking forward to any updates on this, and I'm more than willing to contribute to the discussion if needed.

Best regards, yihong1120

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 10 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

goyalyashpal commented 2 months ago

yeah, the card size (height) for each individual trophy is way toooo small even at column=-1 to be comfortably readable.

only the trophy size at column=3 is good enough.

i don't have any particular will to configure, i just want the defaults (even with many columns) to be sane....

but yeah, this would inevitably require being able to configure to specific needs