ryo-ma / github-profile-trophy

🏆 Add dynamically generated GitHub Stat Trophies on your readme
https://github-profile-trophy.vercel.app
MIT License
5.31k stars 791 forks source link

Include a query where the user can exclude trophies based on title #276

Closed a2ys closed 4 months ago

a2ys commented 5 months ago

This is my first time contributing to this repository.

This pull request adds a feature which helps the user exclude any trophy (or multiple trophies) they don't want to display by title.

For example,

https://github-profile-trophy.vercel.app/?username=ryo-ma&title=-Stars

This would exclude the trophy with the title Stars.

https://github-profile-trophy.vercel.app/?username=ryo-ma&title=-Stars,-Followers

This would exclude the trophies with the title Stars and Followers.

This is similar to excluding trophies based on rank.

This pull request also addresses what might be the primary concern of the author in issue #272.

Also, I ran the following commands based off the CONTRIBUTING.md.

deno task lint
deno task format
deno task test

deno task test gave the following output, and passed the 9 tests.

image

vercel[bot] commented 5 months ago

@a2ys is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-profile-trophy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 7:56am
ryo-ma commented 4 months ago

Can you write README?

a2ys commented 4 months ago

@ryo-ma I updated the README.

RafaelJohn9 commented 4 months ago

👍