ryo-ma / github-profile-trophy

🏆 Add dynamically generated GitHub Stat Trophies on your readme
https://github-profile-trophy.vercel.app
MIT License
5.31k stars 791 forks source link

fix: home page input form #279

Open Jay-Karia opened 4 months ago

Jay-Karia commented 4 months ago

Updates the input form on the home page.

vercel[bot] commented 4 months ago

@Jay-Karia is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

Jay-Karia commented 4 months ago

Creating a form to fetch GitHub trophies is functional but can be improved for readability and efficiency. Firstly, the script tag appears redundant as no script content is included; it can be removed. Additionally, ensuring the placeholder text in the input field matches the button text for consistency is recommended. Here is the revised version:

<form action="https://github-profile-trophy.vercel.app/" method="get">
  <label for="username">GitHub Username</label>
  <input type="text" name="username" id="username" placeholder="Ex. gabriel-logan" required>
  <button type="submit">Get Trophies</button>
</form>

This streamlined version improves readability and maintains functionality without unnecessary elements.

Cool, I'll update it.