ryobg / JContainers

JSON-based data structures for Papyrus - the TESV Skyrim SE scripting language
MIT License
107 stars 23 forks source link

Log file location and missing folder #2

Closed pugwash99 closed 6 years ago

pugwash99 commented 6 years ago

Log file is going to the Oldrim folder,

Line 120 skse_callbacks.cpp '"\My Games\Skyrim\SKSE\' needs changing to '"\My Games\Skyrim Special Edition\SKSE\'

Post install is also not creating the 'Domains' folder under 'Data\SKSE\Plugins\JCData' - willl cause a ctd when starting skyrim if missing.

ryobg commented 6 years ago

Hey thanks! Will check these out. That "Domain" thing somehow I missed, or is it new for SSE? Anyway, will add it (really suprising that missing folder can cause CDT - lol).

javierhimura commented 6 years ago

The domain folder is not new for SSE, i check the nexus download from Oldrim and JContainers zip already contains an empty Domain folder, that is enought to fix the error, and it is better that making the dll create the folder for the first time because a player using Mod Organizer will ends with the folder in their overwrite folder instead the JContainers mod I assume the author include the empty folder to the zip manually and that is why the post-build project does not add that folder to the zip

ryobg commented 6 years ago

I added auto-creation of this folder inside the distro archive. Do you think it will work like that for Mod Organizer?

ryobg commented 6 years ago

Btw, I just tested to load SSE with the plugin, it seems it registers ok. Actual use cases would be better.

ryobg commented 6 years ago

Bummer. Nexus Mod Manager ignores happily that empty Domains folder. There should be something dummy there, ignored during domain search. Or that folder is created at run-time which I see as a possible issue if it fails.

ryobg commented 6 years ago

I feel a bit ashamed of such solution. But nothing better comes to my mind currently.

javierhimura commented 6 years ago

That will explain the weird empty folder that is inside the zip from the version of Oldrim in Nexus It has an empy Domain folder with another empty folder "JContainers_DomainExample" inside and inside there is another empty folder "dummy-file". Probably the last one is the only ignored by NMM

ryobg commented 6 years ago

I have checked too for path references, but its hard to find something else.