ryodeushii / qmk-firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families - fork is Focused on NuPhy Gem80 | Halo75V2 | Air75V2 CFW. If you want to support development of the CFW for Nuphy keyboards - you're welcome here https://buymeacoffee.com/ryodeushii
https://qmk.fm
GNU General Public License v2.0
57 stars 7 forks source link

[Bug] Halo96v2 Num Lock Indicator not working #11

Closed calirng closed 1 week ago

calirng commented 2 weeks ago

Describe the Bug

Pressing Num Lock is supposed to turn on the LED under the NUM key on Halo96v2, but doesn't due to incorrect column index.

Bug found in ansi.c

        if (showNumLock) {
            rgb_matrix_set_color(get_led_index(1, 14), 0x00, 0x80, 0x00);
        }

Fix:

        if (showNumLock) {
            rgb_matrix_set_color(get_led_index(1, 15), 0x00, 0xff, 0xff);
        }

Keyboard Used

Nuphy Halo96v2

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

Other keyboard-related software installed

No response

Additional Context

No response

ryodeushii commented 1 week ago

fixed in #13

ryodeushii commented 1 week ago

@calirng and again, thanks for putting effort into improvements :)