ryohey / signal

Online MIDI Editor: signal
https://signal.vercel.app
MIT License
1.22k stars 137 forks source link

Locks up attempting to edit .mid channels exported from MuseScore #320

Closed pul53gh closed 4 months ago

pul53gh commented 5 months ago

Explanation: For context, I'm in the middle of a project rewriting a marching band piece to run it through Midis2Jam2. When I export the .mid through MuseScore, the instruments are all sorts of mismatched, so I run it through signal so I can reassign and adjust the channels as needed. However, after my latest update to the project, I can't change anything in the file with signal. When I click on one instrument, it freezes with a greyish (my chrome profile is grey so I'm guessing it's just that) screen for a second or two, then allows me to edit the channel, but then when I go to the next instrument, it fully locks up with a solid white screen, and I'm forced to reload the page and start over, which then the same thing will happen.

To Reproduce:

  1. Grab the mid here
  2. Open it
  3. Double click on a channel to edit it's instrument.
  4. If it doesn't lock up yet, open another channel and try to edit it's instrument.
  5. If it doesn't lock up by the second or third change then it might just be my dogshit MacBook

System and Program Info:

ryohey commented 4 months ago

Hi, I could not reproduce it on my device. Does it happen in different browsers?

pul53gh commented 4 months ago

Hello, so I’ve actually fixed it myself. It turns out my MacBook was just so shitty that Signal would crash opening big midi files. It works fine on my pc and other laptop.

On Sat, Mar 9, 2024 at 12:38 AM ryohey @.***> wrote:

Hi, I could not reproduce it on my device. Does it happen in different browsers?

— Reply to this email directly, view it on GitHub https://github.com/ryohey/signal/issues/320#issuecomment-1986739580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7FTIFXNROA7WT5LIAU5GTYXKN6ZAVCNFSM6AAAAABDQJTQ3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWG4ZTSNJYGA . You are receiving this because you authored the thread.Message ID: @.***>

ryohey commented 4 months ago

Thanks for confirming it!