ryohey / signal

Online MIDI Editor: signal
https://signal.vercel.app
MIT License
1.2k stars 136 forks source link

Broken 0-tick long drums with Signal Factory Sound #372

Open spessasus opened 3 weeks ago

spessasus commented 3 weeks ago

Describe the bug It's me again with the same MIDI file. This time the issue is with the drum sounds, sometimes they don't play. issue.zip (this is the exact same th06_01.mid) This is regardless of the soundfont.

To Reproduce Steps to reproduce the behavior:

  1. Load the MIDI file
  2. Mute everything but drums
  3. Wait for the drum section
  4. Hear inconsistent drums

Expected behavior Drums should play fine. For example, try SpessaSynth. It works fine there.

Screenshots N/A

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context (could be helpful)

I've faced this exact problem when making SpessaSynth. The problem is that the note ends immediately after it starts. I fixed it by implementing a minimum allowed note length. The line of code responsible for this.