search

ryokat3 / vscode-qiita-markdown-preview

MIT License
6 stars 2 forks source link

Make annotation of note notation to optional #1

Closed kyntk closed 2 years ago

kyntk commented 2 years ago

Thank you to create Awesome tool!!! I'm so excited to Great experience of this tool!!!

Reference

https://qiita.com/Qiita/items/c686397e4a0f4f11683d#note---%E8%A3%9C%E8%B6%B3%E8%AA%AC%E6%98%8E

What

https://github.com/ryokat3/vscode-qiita-markdown-preview/blob/main/src/qiita-note.ts#L29

:::note
This is also note notation.
:::
ryokat3 commented 2 years ago

Hi @kyntk,

Thank you for your contribution !!

I fully accepted your suggestion and released 0.2.1 with improved 'note' notation validation and rendering. I hope the updated version works as you expect.

kyntk commented 2 years ago

Hi @ryokat3 ,

Thank you for quick response!!!

However, I think it is not enough because we can write something like the following.

:::notehoge
The first word is allowed starting with 'note' but not ending after that.
:::
ryokat3 commented 2 years ago

Hi @kyntk,

Thank you for your report. The case you pointed out had not come to my mind at all... I think it's fixed in Release 0.2.2.

kyntk commented 2 years ago

Hi @ryokat3 ,

Thank you for fixing it! I tried it and it looks good to me, so I'm going to close this issue.