search

ryonakano / konbucase

A case converting app suitable for coding or typing
GNU General Public License v3.0
10 stars 11 forks source link

appdata: `translate=no` properties #125

Closed yakushabb closed 6 months ago

yakushabb commented 6 months ago

It appears that the appstream project no longer supports translatable=no properties, and gettext extract the translatable=no marked strings as translatable.

I opened an issue to inform about the situation, but translatable=no properties are not accepted by developers. You can find the issue here: https://github.com/ximion/appstream/issues/623

Please test your script or string extraction process before merging this PR.

In MetaInfo files, each individual paragraph of a description (or enumerated entry) is translated individually, however, you can only exclude the complete block from being translated by adding translate="no" to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html

ryonakano commented 6 months ago

@yakushabb

gettext extract the translatable=no marked strings as translatable.

I'm on Fedora 39 with gettext 0.22 and AppStream 0.16.1 but haven't seen this. Maybe it's changed in AppStream 1.x?

Anyway, I tested the script or string extraction process (ninja com.github.ryonakano.konbucase-pot command) and these strings won't appear in the generated pot files. Also, appstreamcli validate does not claim any errors, so it's looks good to me.

I saw the issue you opened on the appstream repository and found you're suggesting changes to many projects. Thank you very much for your work!

yakushabb commented 6 months ago

Some gettext version migt not recognize the "translate" properties and can extract strings.

Like your case.

https://github.com/ryonakano/konbucase/commit/33c409d88fc7a729b3c797e39ce5f9e82898d52d

ryonakano commented 6 months ago

Yeah…I found that after merging :weary: