search

ryonakano / konbucase

A case converting app suitable for coding or typing
GNU General Public License v3.0
10 stars 11 forks source link

Fix typo #128

Closed razzeee closed 6 months ago

razzeee commented 6 months ago

I'm unsure, if three primary colors is supported at all, but the typo meant, these were not picked up.

ryonakano commented 6 months ago

Thank you for pointing out the typo!

I'm unsure, if three primary colors is supported at all

The type="primary" seems to be required according to the doc:

A color tag must have a type attribute which denotes the color type. The color type may currently only be primary.

So it should be fine, although it looks weird.

razzeee commented 6 months ago

I did not mean the primary part :)

As we asume, that there is only light and dark, and no third state, the fallback seems weird (the one without scheme)

ryonakano commented 6 months ago

Ah got it. That would be useless, maybe we can remove it :sweat_smile:

razzeee commented 6 months ago

We totally can, at least on flathub I couldn't find another app that does something similar. Still, I was wondering, what you we're trying to do.

ryonakano commented 6 months ago

I don't remember what I meant here, but it looks like elementary AppCenter, where I publish this app to, looks like to use this line instead of lines with scheme:

https://github.com/elementary/appcenter/blob/f8db5192b69da0846fa9e62f789e15e0dbf0cf29/src/Core/Package.vala#L826

I'm not sure why AppCenter refer to the lines with scheme though.

razzeee commented 6 months ago

It should fallback to that, in the abscence of either dark/light from my understanding of the spec - but the code looks weird indeed (from very far away)

Might just be too old.