search

ryppl / Boost2Git

Conversion to Git for Boost
http://jenkins.boost.org/job/Boost2Git
5 stars 6 forks source link

Now UTF-16 handling EOL fixup patch #42

Open ned14 opened 11 years ago

ned14 commented 11 years ago

Passes the boost SVN Dave sent me. I now know why my boost svnsynced copy didn't fault - I didn't sync sandbox, and sandbox is what contains the UTF-16.

BTW a quick note: some of the warnings about having to convert EOL in some of the sandbox files refer to filenames saying something like "bad_end_of_line_test.txt". I am almost certain that files named like that have intentionally incorrect EOLs and they want them to stay that way.

I'd recommend those affected to not use .txt for such test files (which stops Boost2Git messing with the file), and it might be an idea to add a new "binary text" extension to gitattributes for that sort of file to ensure git doesn't try fiddling with the contents either during checkout.

Niall

dabrahams commented 11 years ago

w.r.t. intentionally-bad line endings, you can just mark those specific filenames as binary in .gitattributes, can't you?

ned14 commented 11 years ago

@dabrahams You can add any glob matching said files to .gitattributes e.g. bad_eol_test*.txt or whatever. Full paths also qualify of course, but I'm thinking some wildcard pattern or special file extension to indicate deliberately malformed text would help users transition their files correctly. Even adding a .bin extension would be enough I think.

ned14 commented 11 years ago

How has this patchset fared? Does it solve the original problem successfully? Niall