search

ryrych / rcarousel

yet another jQuery UI carousel
http://ryrych.github.com/rcarousel/
172 stars 48 forks source link

Even distribution of items #15

Closed ralftar closed 12 years ago

ralftar commented 12 years ago

Four elements with auto scroll and one step gives the following page sequence:

1 2 3 2 3 4 1 2 3 ... etc.

As you know/can see it slides three steps from the second to the third page sequence, which users can find annoying. Additionally item 2 and 3 are always displayed, and item 1 and 4 are displayed partially.

I find the following sequence to be more comforting, in addition to an equal distribution of the various items:

1 2 3 2 3 4 3 4 1 4 1 2 1 2 3 .. etc

Is this currently applicable?

ryrych commented 12 years ago

I know what you are talking about since the first version of the pagination algorithm worked like that. But you ended up with many, many pages with custom number of visible elements and step.

I was considering to restore this as an option and you have confirmed that this may be useful.

But you must wait for a new feature release when it is done. When? I don’t know.

ralftar commented 12 years ago

Thanks for the quick and confirming replay.

Also thanks for a great carousel!

sammdec commented 12 years ago

Is there any update on this? I tried hacking around with the current build to no avail unfortunately.

Thankyou

ryrych commented 12 years ago

No, and I don’t feel like working on the carousel now.

sammdec commented 12 years ago

Oh right ok. No problems. Dont suppose you have any other carousels you recommend?

ryrych commented 12 years ago

nope

JasonNewell commented 12 years ago

I needed this functionality, so I hacked it in.

To be clear, this is an absolutely awful hack built under a deadline. It hasn't been tested with the examples. It was built for one specific case, and may not work for you. It's also likely to be significantly less efficient (especially for step > 1, if that even works at all). There is a pretty good reason why this type of functionality was removed from the original versions.

Anyway: http://pastebin.com/8pZFGtrw

Hope this helps!

ryrych commented 11 years ago

Hi Jason! I’m glad to see that there is still large interest about rcarousel. :) I don’t think that good implementation of this is less efficient, but I agree for 100 per cent that figuring out how to code it is ‘pretty’ tricky. Maybe I’ll find some time sometime in the future to work on this.

JasonNewell commented 11 years ago

Thanks for the reply, and rcarousel itself – it was extremely helpful. I'm getting into writing jQuery UI widgets, and may do a better 'non-hack' implementation that adds this as an option in the future. I'll let you know if/when I do.

Thanks, Jason Newell | Developer | Susco & Touch Studios 1215 Prytania St. | Suite 371 | New Orleans, LA 70130 DL: (504) 667-5538 F: (504) 264-9345 jason.newell@suscotouch.com

From: Wojciech Ryrych notifications@github.com<mailto:notifications@github.com> Reply-To: ryrych/rcarousel reply@reply.github.com<mailto:reply@reply.github.com> Date: Fri, 28 Sep 2012 08:14:34 -0700 To: ryrych/rcarousel rcarousel@noreply.github.com<mailto:rcarousel@noreply.github.com> Cc: Jason Newell jason.newell@touchstudios.net<mailto:jason.newell@touchstudios.net> Subject: Re: [rcarousel] Even distribution of items (#15)

Hi Jason! I’m glad to see that there is still large interest about rcarousel. :) I don’t think that good implementation of this is less efficient, but I agree for 100 per cent that figuring out how to code it is ‘pretty’ tricky. Maybe I’ll find some time sometime in the future to work on this.

— Reply to this email directly or view it on GitHubhttps://github.com/ryrych/rcarousel/issues/15#issuecomment-8979587.

ryrych commented 11 years ago

That’s definitely a good way to learn! I was doing the same and ended up with two kinda popular jQuery UI widgets.

larze commented 11 years ago

Jason,

Thank you for the "hack". If this feature were to be added to rCarousel in the future, it would be extremely helpful.

jasonbnewell commented 11 years ago

I've forked the project and added this feature as an option (tested with all examples). Also made a pull request that I hope will be accepted. In the meantime, you can get it here: https://github.com/jasonbnewell/rcarousel .

Enabling the option WILL cause extra pages to be generated in some cases, but I didn't notice any difference in performance with the examples.

ryrych commented 11 years ago

Thanks Jason. Unfortunately as I have a new job and lots of things to learn, I can't support this project ATM. It's low on my priorities list. But I'm glad that you like the project and since it's open, you can do with it virtually whatever you like.

JasonNewell commented 11 years ago

I thought that was likely to be the case. I understand. It was fun to work on anyway, and hopefully my fork will be of some use to people.

If you ever get back to it, please give my changes a look. You should find that it's consistent with your code style, and that there are a good selection of examples to help you verify that it didn't break anything.

Thanks, Jason Newell