search

ryrych / rcarousel

yet another jQuery UI carousel
http://ryrych.github.com/rcarousel/
172 stars 48 forks source link

Widget namespace should be other than 'ui.' #16

Open rdworth opened 12 years ago

rdworth commented 12 years ago

The 'ui.' widget namespace is reserved for widgets that are part of the jQuery UI Suite (http://jqueryui.com/). It is intended that developers building their own widgets using the jQuery UI Widget Factory select their own namespace so as to avoid a collision with a current or future plugin of the same name in a suite maintained by a separate bunch of folks.

The fix is simple enough. On line https://github.com/ryrych/rcarousel/blob/master/widget/lib/jquery.ui.rcarousel.js#L2 just change 'ui' to a namespace of your choosing, such as 'r' or 'ry' or 'ryry' or 'ryrych' or something else entirely. Also, don't forget to update the filename to reflect the change. The filename should generally be jquery.namespace.widgetname.js

Thanks!

ryrych commented 12 years ago

Yes, I know. I read this text a few days ago. As I’m working now on a new version, this will be changed when it is released. Thanks.

ryrych commented 12 years ago

Oh, sorry. I thought it relates to rlightbox that I’m working on now. Anyway it will also be changed in rcarousel.