ryryry-3302 / pe

0 stars 0 forks source link

Case sensitivity of find_student command #10

Open ryryry-3302 opened 3 days ago

ryryry-3302 commented 3 days ago

From course guidelines of bug triaging under feature flaws

image.png

Based on the course instructions there is no reason for find_student to be case sensitive as names are not case sensitive in real life

example below image.png

soc-pe-bot commented 5 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitiveness for name in find command

image.png

As per the course website: "In general, case sensitivity of something should follow the case sensitivity of the real world entity it represents e.g., as person names are not case-sensitive in the real world, they shouldn't be case-sensitive in the app either. The same applies for search keywords. Incorrect case sensitivity can be considered a FeatureFlaw."

Hence, I find that the name in find command should not be case sensitive.


[original: nus-cs2113-AY2425S1/pe-interim#133] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your bug report.

We agree with the premise of your argument, but we feel that the severity is low as our UG specifies that the command is case-sensitive and our product works in those cases.

Moreover, the impact on users is mitigated by the find command being an endpoint command; hence, no other commands will depend on it.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]